Change the path to create notebooks in when navigating directories#3264
Merged
Carreau merged 2 commits intojupyter:masterfrom Jan 27, 2018
Merged
Change the path to create notebooks in when navigating directories#3264Carreau merged 2 commits intojupyter:masterfrom
Carreau merged 2 commits intojupyter:masterfrom
Conversation
Member
Author
|
I haven't fully understood the issue with the list showing the previous directory yet, but what I have found is that:
|
Member
Author
|
Educated guesswork led me to use |
Member
Author
Member
|
Haven't looked at notebook codebase in a while but this look good to me. |
Contributor
|
Thanks for fixing this @takluyver! I think that releasing a patch for this is a good idea as it's a regression that was reported by several people. Let me know if I can help with that 👍 |
Member
Author
|
I've released 5.4 to PyPI with the fix (and a few other changes). Now to update conda-forge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-3263
Closes gh-3248
There's still an issue where the dashboard goes back to showing the root directory when you create a notebook. I'll look into that later.