Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the path to create notebooks in when navigating directories #3264

Merged
merged 2 commits into from Jan 27, 2018

Conversation

Projects
None yet
3 participants
@takluyver
Copy link
Member

takluyver commented Jan 25, 2018

Closes gh-3263
Closes gh-3248

There's still an issue where the dashboard goes back to showing the root directory when you create a notebook. I'll look into that later.

@takluyver takluyver added this to the 5.3.2 milestone Jan 25, 2018

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Jan 25, 2018

I haven't fully understood the issue with the list showing the previous directory yet, but what I have found is that:

  • I can trigger it by creating a new text file or a directory, as well as a new notebook.
  • The onpopstate() handler we add is getting called, for some reason.
@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Jan 26, 2018

Educated guesswork led me to use event.preventDefault() on the links that make new files and folders, which seems to fix the issue with the files list jumping back to a previous state.

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Jan 26, 2018

@gnestor @Carreau if you have a chance to review this, I think the issue is worth doing a 5.3.2 bugfix release for. I can make the release tomorrow if this gets merged.

@Carreau

This comment has been minimized.

Copy link
Contributor

Carreau commented Jan 27, 2018

Haven't looked at notebook codebase in a while but this look good to me.
Happy if we make a 5.3.2.

@Carreau Carreau merged commit b96d758 into jupyter:master Jan 27, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 8441005...51acfb6
Details
codecov/project 78.76% remains the same compared to 8441005
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the takluyver:i3263 branch Jan 27, 2018

@takluyver takluyver modified the milestones: 5.3.2, 5.4 Jan 27, 2018

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Jan 28, 2018

Thanks for fixing this @takluyver! I think that releasing a patch for this is a good idea as it's a regression that was reported by several people. Let me know if I can help with that 👍

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Jan 28, 2018

I've released 5.4 to PyPI with the fix (and a few other changes). Now to update conda-forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.