Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clicking with modifiers, page title updates #3282

Merged
merged 2 commits into from Feb 2, 2018

Conversation

Projects
None yet
2 participants
@parente
Copy link
Member

parente commented Jan 31, 2018

  • Allow the default browser behavior when the user is holding any modifier key while clicking on a folder or breadcrumb in the fileview.
  • Update the page title when navigating via the History API

Fixes #3276, fixes #3277

parente added some commits Jan 31, 2018

Fix modified clicking of dirs, crumbs
All the default browser behavior when the user is holding any modifier
key while clicking on a folder or breadcrumb in the fileview.

@parente parente changed the title Fix modified clicking of dirs, crumbs Fix modified clicking of directories, crumbs Jan 31, 2018

@parente parente changed the title Fix modified clicking of directories, crumbs Fix clicking with modifiers, page title updates Jan 31, 2018

@takluyver takluyver added this to the 5.5 milestone Feb 2, 2018

@takluyver takluyver merged commit 6d7fd5c into jupyter:master Feb 2, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 3de5e50...386b3a2
Details
codecov/project 78.76% remains the same compared to 3de5e50
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Feb 2, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.