Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slides exportation/download to the menu #3287

Merged
merged 2 commits into from Feb 2, 2018

Conversation

Projects
None yet
2 participants
@damianavila
Copy link
Member

damianavila commented Feb 1, 2018

This is something missing for a long time.
JupyterLab offers it as well.
And with the upcoming change in nbconvert about catching reveal.js from the CDN (by default), you get an exported/downloaded html file that you can open immediately to surf the slides.

@damianavila damianavila requested review from gnestor and takluyver Feb 1, 2018

@takluyver
Copy link
Member

takluyver left a comment

Makes sense, thanks. One minor quibble...

@@ -109,6 +109,7 @@
<li id="download_ipynb"><a href="#">{% trans %}Notebook (.ipynb){% endtrans %}</a></li>
<li id="download_script"><a href="#">{% trans %}Script{% endtrans %}</a></li>
<li id="download_html"><a href="#">{% trans %}HTML (.html){% endtrans %}</a></li>
<li id="download_slides"><a href="#">{% trans %}Reveal.js Slides (.html){% endtrans %}</a></li>

This comment has been minimized.

@takluyver

takluyver Feb 2, 2018

Member

I'd say that 'slides' should be lower case.

This comment has been minimized.

@damianavila

damianavila Feb 2, 2018

Author Member

OK, will make the change.

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Feb 2, 2018

The test failure is unrelated - a broken link in the docs. I've opened #3292 to figure out if we can be smarter about checking the links.

@takluyver takluyver merged commit a812581 into jupyter:master Feb 2, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@damianavila

This comment has been minimized.

Copy link
Member Author

damianavila commented Feb 2, 2018

The test failure is unrelated - a broken link in the docs. I've opened #3292 to figure out if we can be smarter about checking the links.

Thanks!
What do you suggest to do in the meantime? Remove the offending link? Merge as is? Thoughts welcome 😉

@takluyver takluyver added this to the 5.5 milestone Feb 2, 2018

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Feb 2, 2018

I've made #3293 to fix the link, and merged this one.

@damianavila

This comment has been minimized.

Copy link
Member Author

damianavila commented Feb 2, 2018

What do you suggest to do in the meantime? Remove the offending link? Merge as is? Thoughts welcome 😉

Well, you pressed the merge button at the same time I was submitting my answer, funny!

@damianavila damianavila deleted the damianavila:add_slides_export branch Feb 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.