Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #3288

Merged
merged 2 commits into from Feb 12, 2018
Merged

Minor fixes #3288

merged 2 commits into from Feb 12, 2018

Conversation

@kant
Copy link
Contributor

@kant kant commented Feb 1, 2018

(proposal)

(proposal)
@takluyver
Copy link
Member

@takluyver takluyver commented Feb 1, 2018

Maybe use *asterisks for italics* rather than backticks. The meaning of backticks is configurable in rst, and in some of our docs we configure it to mean inline code.

Loading

@kant
Copy link
Contributor Author

@kant kant commented Feb 2, 2018

Understood!

Loading

@takluyver
Copy link
Member

@takluyver takluyver commented Feb 5, 2018

Ping? If you've got a moment to switch it to asterisks, I'm happy to merge this.

Loading

@takluyver takluyver added this to the 5.5 milestone Feb 12, 2018
@takluyver takluyver merged commit b76c8d9 into jupyter:master Feb 12, 2018
1 of 2 checks passed
Loading
@takluyver
Copy link
Member

@takluyver takluyver commented Feb 12, 2018

I made the change myself to tidy this up.

Loading

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants