#1097 Add close and halt to shortcut menu #3314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
reviewed
Feb 7, 2018
| }; | ||
| // finish with close on success or failure | ||
| that.notebook.session.delete(close_window, close_window); | ||
| that.notebook.close_and_halt(); |
Member
There was a problem hiding this comment.
Now that there's an action for this, it should be possible to remove the handler function, and connect it via id_actions_dict below.
Contributor
Author
There was a problem hiding this comment.
Ok Thanks! Would it be helpful to change the id from 'kill_and_exit' to 'close_and_halt' in the html for consistency? or vice versa?
Member
|
There are some tests failing because they look for the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi this is my first pull request for the jupyter notebook project! This is a fix for issue #1097. I appreciate any feedback.