Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1097 Add close and halt to shortcut menu #3314

Merged
merged 4 commits into from Feb 8, 2018

Conversation

mfdooom
Copy link
Contributor

@mfdooom mfdooom commented Feb 7, 2018

Hi this is my first pull request for the jupyter notebook project! This is a fix for issue #1097. I appreciate any feedback.

};
// finish with close on success or failure
that.notebook.session.delete(close_window, close_window);
that.notebook.close_and_halt();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that there's an action for this, it should be possible to remove the handler function, and connect it via id_actions_dict below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok Thanks! Would it be helpful to change the id from 'kill_and_exit' to 'close_and_halt' in the html for consistency? or vice versa?

@takluyver takluyver added this to the 5.5 milestone Feb 7, 2018
@takluyver
Copy link
Member

There are some tests failing because they look for the kill_and_exit ID - could you update the test so it looks for the new ID?

@takluyver takluyver merged commit e398156 into jupyter:master Feb 8, 2018
@mfdooom mfdooom deleted the 1097-close-halt branch February 8, 2018 13:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants