Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1097 Add close and halt to shortcut menu #3314

Merged
merged 4 commits into from Feb 8, 2018

Conversation

Projects
None yet
2 participants
@Shels1909
Copy link
Contributor

Shels1909 commented Feb 7, 2018

Hi this is my first pull request for the jupyter notebook project! This is a fix for issue #1097. I appreciate any feedback.

};
// finish with close on success or failure
that.notebook.session.delete(close_window, close_window);
that.notebook.close_and_halt();

This comment has been minimized.

@takluyver

takluyver Feb 7, 2018

Member

Now that there's an action for this, it should be possible to remove the handler function, and connect it via id_actions_dict below.

This comment has been minimized.

@Shels1909

Shels1909 Feb 7, 2018

Author Contributor

Ok Thanks! Would it be helpful to change the id from 'kill_and_exit' to 'close_and_halt' in the html for consistency? or vice versa?

@takluyver takluyver added this to the 5.5 milestone Feb 7, 2018

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Feb 7, 2018

There are some tests failing because they look for the kill_and_exit ID - could you update the test so it looks for the new ID?

@takluyver takluyver merged commit e398156 into jupyter:master Feb 8, 2018

4 checks passed

codecov/patch Coverage not affected when comparing e250b0b...9b9c191
Details
codecov/project 78.76% remains the same compared to e250b0b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Shels1909 Shels1909 deleted the Shels1909:1097-close-halt branch Feb 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.