Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing import _ #3316

Merged
merged 2 commits into from Feb 8, 2018

Conversation

Projects
None yet
2 participants
@ehengao
Copy link
Contributor

ehengao commented Feb 8, 2018

No description provided.

ehengao added some commits Feb 8, 2018

@ehengao

This comment has been minimized.

Copy link
Contributor Author

ehengao commented Feb 8, 2018

Hope this can merge to the latest version cos code breaked not doing this.

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Feb 8, 2018

This isn't actually broken - the _ gets installed to builtins, so it's available everywhere without needing to import it. But I now think we're better off putting the imports in than forever explaining how it's meant to work.

@takluyver takluyver added this to the 5.5 milestone Feb 8, 2018

@takluyver takluyver merged commit 0db7ef7 into jupyter:master Feb 8, 2018

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 78.76% (+<.01%) compared to e250b0b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.