Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add any extra installed nbconvert exporters to the "Download as" menu #3323

Merged
merged 2 commits into from Feb 12, 2018

Conversation

Projects
None yet
3 participants
@mdboom
Copy link
Contributor

mdboom commented Feb 9, 2018

It would be nice if extra nbconvert exporters show up on the "File -> Download as" menu, without the need to write a custom Javascript extension.

Of course, some exporters will have required parameters, so this system is opt-in -- the exporter must define the export_from_notebook menu to provide a friendly (and possibly translatable) name to the menu.

<li id="download_{{ exporter.name }}">
<a href="#">{{ exporter.display }}</a>
</li>
</span>

This comment has been minimized.

@minrk

minrk Feb 9, 2018

Member

extra closing span?

This comment has been minimized.

@mdboom

mdboom Feb 9, 2018

Author Contributor

Oops. Thanks.

@takluyver takluyver added this to the 5.5 milestone Feb 12, 2018

@takluyver takluyver merged commit 64f02d8 into jupyter:master Feb 12, 2018

4 checks passed

codecov/patch 81.81% of diff hit (target 0%)
Details
codecov/project 78.77% (+<.01%) compared to e398156
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Feb 12, 2018

Thanks!

@mdboom

This comment has been minimized.

Copy link
Contributor Author

mdboom commented Feb 12, 2018

Thanks for the merge. Just a heads up (in case it was missed): jupyter/nbconvert#759 documents this feature over in nbconvert land. That seemed like the most logical place, but if not let me know, and I can submit something for notebook.

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Feb 12, 2018

Thanks for the heads up, I had missed that connection. I think the way you've documented it makes sense. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.