Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install gettext into builtins #3330

Merged
merged 3 commits into from Feb 12, 2018

Conversation

Projects
None yet
1 participant
@takluyver
Copy link
Member

takluyver commented Feb 12, 2018

With the merge of #3326, I think this is no longer needed. Having _ in builtins seems convenient, but it turns out that most of the code using it is in a few files, and breaking the normal namespacing rules has caused various problems and confusions.

@takluyver takluyver added this to the 5.5 milestone Feb 12, 2018

Allow use of newest nbsphinx for building docs
Needed for compatibility with Sphinx 1.7
@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Feb 12, 2018

This also unpins nbsphinx for the docs build. Completely unrelated, but it's needed to make the tests pass, as sphinx 1.7 just got released.

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Feb 12, 2018

Merging so that the tests pass again.

@takluyver takluyver merged commit f3df01e into jupyter:master Feb 12, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 4ad6517...83fd9bb
Details
codecov/project 78.77% (+<.01%) compared to 4ad6517
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the takluyver:no-gettext-builtin branch Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.