Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install gettext into builtins #3330

Merged
merged 3 commits into from Feb 12, 2018
Merged

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Feb 12, 2018

With the merge of #3326, I think this is no longer needed. Having _ in builtins seems convenient, but it turns out that most of the code using it is in a few files, and breaking the normal namespacing rules has caused various problems and confusions.

@takluyver takluyver added this to the 5.5 milestone Feb 12, 2018
Needed for compatibility with Sphinx 1.7
@takluyver
Copy link
Member Author

@takluyver takluyver commented Feb 12, 2018

This also unpins nbsphinx for the docs build. Completely unrelated, but it's needed to make the tests pass, as sphinx 1.7 just got released.

Loading

@takluyver
Copy link
Member Author

@takluyver takluyver commented Feb 12, 2018

Merging so that the tests pass again.

Loading

@takluyver takluyver merged commit f3df01e into jupyter:master Feb 12, 2018
4 checks passed
Loading
@takluyver takluyver deleted the no-gettext-builtin branch Feb 12, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant