Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in i18n/README.md #3367

Merged
merged 2 commits into from Mar 1, 2018
Merged

fix error in i18n/README.md #3367

merged 2 commits into from Mar 1, 2018

Conversation

@forbxy
Copy link
Contributor

@forbxy forbxy commented Feb 23, 2018

my computer working on Ubuntu,so I just test it on Ubuntu,I can not confirm if it is necessary to set environment variable LANGUAGE on other linux system

@@ -15,6 +15,7 @@ However…
run in).

Hint: if running Windows, you can set it in PowerShell with `${Env:LANG} = "xx_XX"`.
if running Ubuntu, you should set environment variable `LANGUAGE="xx_XX"`.
Copy link
Member

@takluyver takluyver Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least on my system, there's a variable called LANG rather than LANGUAGE. I think both are used, but I'm not sure which one has priority.

Loading

Copy link
Contributor Author

@forbxy forbxy Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on my system(ubuntu14.04),LANG don't work

Loading

Copy link
Member

@willingc willingc Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forbxy If you are ssh'ing into Ubuntu 14.04, you will need to make sure that the following are set:

export LANG="en_US.utf8"
export LANGUAGE="en_US.utf8"
export LC_ALL="en_US.utf8"

Loading

@forbxy
Copy link
Contributor Author

@forbxy forbxy commented Mar 1, 2018

finally,I test it on ubuntu 16,var LANGUAGE is needless

Loading

@minrk minrk merged commit 95a8340 into jupyter:master Mar 1, 2018
4 checks passed
Loading
@takluyver takluyver added this to the 5.5 milestone Apr 24, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants