Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in i18n/README.md #3367

Merged
merged 2 commits into from Mar 1, 2018

Conversation

Projects
None yet
4 participants
@forbxy
Copy link
Contributor

forbxy commented Feb 23, 2018

my computer working on Ubuntu,so I just test it on Ubuntu,I can not confirm if it is necessary to set environment variable LANGUAGE on other linux system

@@ -15,6 +15,7 @@ However…
run in).

Hint: if running Windows, you can set it in PowerShell with `${Env:LANG} = "xx_XX"`.
if running Ubuntu, you should set environment variable `LANGUAGE="xx_XX"`.

This comment has been minimized.

@takluyver

takluyver Feb 26, 2018

Member

At least on my system, there's a variable called LANG rather than LANGUAGE. I think both are used, but I'm not sure which one has priority.

This comment has been minimized.

@forbxy

forbxy Feb 26, 2018

Author Contributor

on my system(ubuntu14.04),LANG don't work

This comment has been minimized.

@willingc

willingc Feb 26, 2018

Member

@forbxy If you are ssh'ing into Ubuntu 14.04, you will need to make sure that the following are set:

export LANG="en_US.utf8"
export LANGUAGE="en_US.utf8"
export LC_ALL="en_US.utf8"
@forbxy

This comment has been minimized.

Copy link
Contributor Author

forbxy commented Mar 1, 2018

finally,I test it on ubuntu 16,var LANGUAGE is needless

@minrk minrk merged commit 95a8340 into jupyter:master Mar 1, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 25c628c...eb9d200
Details
codecov/project 77.93% remains the same compared to 25c628c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver added this to the 5.5 milestone Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.