Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:when upload large file,we cant stop #3373

Merged
merged 2 commits into from Mar 8, 2018
Merged

Conversation

@forbxy
Copy link
Contributor

@forbxy forbxy commented Feb 25, 2018

the cancel button' action only remove its html item, don't stop upload event before

@@ -1220,12 +1220,14 @@ define([
NotebookList.prototype.add_large_file_upload_button = function (file) {
var that = this;
var item = that.new_item(0, true);
var stop_singnal = false;
Copy link
Member

@takluyver takluyver Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

singnal -> signal

Copy link
Member

@takluyver takluyver Mar 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @forbxy - can you make this spelling change?

@@ -1276,6 +1278,9 @@ define([
var upload_file = null;

var large_reader_onload = function (event) {
if (stop_singnal === true) {
return;
Copy link
Member

@takluyver takluyver Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@forbxy forbxy Feb 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file reader is a local variable,one chunk one file reader var,we stopped before new file reader create (after last chunk uploaded), so we don't need to abort file reader

Copy link
Contributor Author

@forbxy forbxy Mar 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I make a commit to fix the word(singnal)?or it is already changed after you review?

Copy link
Member

@takluyver takluyver Mar 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to make a commit to fix it - my comment was just pointing it out.

@takluyver takluyver added this to the 5.5 milestone Mar 8, 2018
@takluyver takluyver merged commit c1c7d3d into jupyter:master Mar 8, 2018
4 checks passed
@takluyver
Copy link
Member

@takluyver takluyver commented Mar 8, 2018

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants