Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clear login cookie on requests without cookie #3380

Merged
merged 1 commit into from Mar 5, 2018

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Feb 27, 2018

Clearing the secure cookie makes sense when it is invalid or expired, but clearing it when it's not sent with a request can unexpectedly log the user out.

I ran into this with misconstructed URLs which didn't incorporate base_url. That was itself a bug, but the result of suddenly being unauthenticated makes it harder to track down.

Closes gh-3365 (hopefully)
Possibly also relevant to gh-2396

I'm not sure why this seems to affect Firefox more than Chrome.

Clearing the secure cookie makes sense when it is invalid or expired,
but clearing it when it's not sent with a request can unexpectedly log
the user out.

I ran into this with misconstructed URLs which didn't incorporate
base_url. That was itself a bug, but the result of suddenly being
unauthenticated makes it harder to track down.

Closes jupytergh-3365 (hopefully)
Possibly also relevant to jupytergh-2396

I'm not sure why this seems to affect Firefox more than Chrome.
@takluyver
Copy link
Member Author

@takluyver takluyver commented Feb 28, 2018

One user on #3365 has confirmed that this fixed their issue.

Loading

@takluyver
Copy link
Member Author

@takluyver takluyver commented Mar 5, 2018

Loading

gnestor
gnestor approved these changes Mar 5, 2018
@gnestor
Copy link
Contributor

@gnestor gnestor commented Mar 5, 2018

LGTM!

Loading

@minrk minrk merged commit f00215b into jupyter:master Mar 5, 2018
4 checks passed
Loading
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants