Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clear login cookie on requests without cookie #3380

Merged
merged 1 commit into from Mar 5, 2018

Conversation

Projects
None yet
3 participants
@takluyver
Copy link
Member

takluyver commented Feb 27, 2018

Clearing the secure cookie makes sense when it is invalid or expired, but clearing it when it's not sent with a request can unexpectedly log the user out.

I ran into this with misconstructed URLs which didn't incorporate base_url. That was itself a bug, but the result of suddenly being unauthenticated makes it harder to track down.

Closes gh-3365 (hopefully)
Possibly also relevant to gh-2396

I'm not sure why this seems to affect Firefox more than Chrome.

Don't clear login cookie on requests without cookie
Clearing the secure cookie makes sense when it is invalid or expired,
but clearing it when it's not sent with a request can unexpectedly log
the user out.

I ran into this with misconstructed URLs which didn't incorporate
base_url. That was itself a bug, but the result of suddenly being
unauthenticated makes it harder to track down.

Closes gh-3365 (hopefully)
Possibly also relevant to gh-2396

I'm not sure why this seems to affect Firefox more than Chrome.
@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Feb 28, 2018

One user on #3365 has confirmed that this fixed their issue.

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Mar 5, 2018

@gnestor

gnestor approved these changes Mar 5, 2018

@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Mar 5, 2018

LGTM!

@minrk minrk merged commit f00215b into jupyter:master Mar 5, 2018

4 checks passed

codecov/patch 33.33% of diff hit (target 0%)
Details
codecov/project 77.75% (-0.18%) compared to a1fb317
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.