Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log OSErrors failing to create less-critical files during startup #3384

Merged
merged 1 commit into from Feb 28, 2018

Conversation

Projects
None yet
3 participants
@minrk
Copy link
Member

minrk commented Feb 28, 2018

rather than fatal errors

we can't solve every problem (e.g. the nbsignature db is required to function properly), but this makes it a little less likely to give up when the disk is full, giving users a better chance to recover space by launching a terminal.

coming up with full disks in jupyterhub deployments: jupyterhub/zero-to-jupyterhub-k8s#518

@willingc
Copy link
Member

willingc left a comment

Looks good. Thanks @minrk

@willingc willingc merged commit 1b99df9 into jupyter:master Feb 28, 2018

4 checks passed

codecov/patch 60% of diff hit (target 0%)
Details
codecov/project 78.21% (+0.28%) compared to a1fb317
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@minrk minrk deleted the minrk:fail-to-write branch Mar 1, 2018

@takluyver takluyver added this to the 5.5 milestone Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.