Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding description for 'Trusted' widgets #3386

Merged
merged 2 commits into from Mar 1, 2018

Conversation

Projects
None yet
3 participants
@ashleytqy
Copy link
Contributor

ashleytqy commented Mar 1, 2018

This PR fixes #2707

  • Trusted and Untrusted widgets have title attributes which describe what they mean
  • Trusted widgets now have their clicks disabled

screen shot 2018-02-28 at 10 13 38 pm

@minrk

This comment has been minimized.

Copy link
Member

minrk commented Mar 1, 2018

Nice!

@minrk minrk merged commit e9da502 into jupyter:master Mar 1, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 1b99df9...978e16a
Details
codecov/project 77.89% remains the same compared to 1b99df9
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver added this to the 5.5 milestone Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.