Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tests running with tornado 5 #3398

Merged
merged 2 commits into from Mar 5, 2018

Conversation

Projects
None yet
3 participants
@minrk
Copy link
Member

minrk commented Mar 5, 2018

tornado 5 has just been released. The notebook itself has been updated to work with tornado 5 in the latest releases, but we never ran the tests for this repo with --pre dependencies, so the last remaining compatibility fixes which were only in the tests themselves never got caught.

Actual fixes:

  • ensure asyncio eventloop is running in the test thread (tornado 4.x creates per-thread loops as needed, asyncio must be asked)
  • one last io_loop= arg that's been removed

While at it, update test installation so this should be caught sooner:

  • install test dependencies with --pre to get more warning about upcoming releases that might cause breakages
  • remove use of old 'travis-wheels' repo which only has out-of-date packages at this point

cc @blink1073

minrk added some commits Mar 5, 2018

tornado 5 fixes in tests
- start asyncio loop explicitly in notebook thread (tornado 4 starts per-thread loops automatically, asyncio doesn’t)
- remove unsupported ‘io_loop=‘ arg in websocket test

application runs fine with tornado 5, just a few test bits needed updating
install test dependencies with —pre
to get more warning about upcoming releases that might cause breakages
@blink1073
Copy link
Member

blink1073 left a comment

Thanks!

@minrk minrk referenced this pull request Mar 5, 2018

Closed

Test with Tornado 5.0b1 #317

@minrk minrk merged commit ae1f167 into jupyter:master Mar 5, 2018

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 77.88% (+0.54%) compared to 95a8340
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@minrk minrk deleted the minrk:tornado5 branch Mar 5, 2018

@takluyver takluyver added this to the 5.5 milestone Mar 7, 2018

jcb91 added a commit to jcb91/jupyter_nbextensions_configurator that referenced this pull request Mar 9, 2018

takluyver added a commit that referenced this pull request Mar 16, 2018

Merge pull request #3398 from minrk/tornado5
Get tests running with tornado 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.