Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tests running with tornado 5 #3398

Merged
merged 2 commits into from Mar 5, 2018
Merged

Get tests running with tornado 5 #3398

merged 2 commits into from Mar 5, 2018

Conversation

@minrk
Copy link
Member

@minrk minrk commented Mar 5, 2018

tornado 5 has just been released. The notebook itself has been updated to work with tornado 5 in the latest releases, but we never ran the tests for this repo with --pre dependencies, so the last remaining compatibility fixes which were only in the tests themselves never got caught.

Actual fixes:

  • ensure asyncio eventloop is running in the test thread (tornado 4.x creates per-thread loops as needed, asyncio must be asked)
  • one last io_loop= arg that's been removed

While at it, update test installation so this should be caught sooner:

  • install test dependencies with --pre to get more warning about upcoming releases that might cause breakages
  • remove use of old 'travis-wheels' repo which only has out-of-date packages at this point

cc @blink1073

minrk added 2 commits Mar 5, 2018
- start asyncio loop explicitly in notebook thread (tornado 4 starts per-thread loops automatically, asyncio doesn’t)
- remove unsupported ‘io_loop=‘ arg in websocket test

application runs fine with tornado 5, just a few test bits needed updating
to get more warning about upcoming releases that might cause breakages
Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

Loading

@minrk minrk merged commit ae1f167 into jupyter:master Mar 5, 2018
4 checks passed
Loading
@minrk minrk deleted the tornado5 branch Mar 5, 2018
@takluyver takluyver added this to the 5.5 milestone Mar 7, 2018
jcb91 added a commit to jcb91/jupyter_nbextensions_configurator that referenced this issue Mar 9, 2018
takluyver added a commit that referenced this issue Mar 16, 2018
Get tests running with tornado 5
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants