Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add settings['activity_sources'] #3401

Merged
merged 2 commits into from Mar 16, 2018

Conversation

Projects
None yet
2 participants
@minrk
Copy link
Member

minrk commented Mar 6, 2018

for extensions to register activity that should prevent shutdown due to inactivity

add settings[‘activity_sources’]
for extensions to register activity that should prevent shutdown due to inactivity
@@ -264,6 +264,8 @@ def init_settings(self, jupyter_app, kernel_manager, contents_manager,

# Jupyter stuff
started=now,
# place for extensions to register activity
activity_sources={},

This comment has been minimized.

@takluyver

takluyver Mar 7, 2018

Member

'sources' suggests to me that it contains something like functions you call to get activity timestamps. Maybe call it something like last_activity_times?

This comment has been minimized.

@takluyver

takluyver Mar 13, 2018

Member

Ping @minrk . I can do the name change if you're OK with it.

This comment has been minimized.

@minrk

minrk Mar 16, 2018

Author Member

Sorry, just got back to it

@takluyver takluyver added this to the 5.5 milestone Mar 13, 2018

@minrk minrk force-pushed the minrk:activity_sources branch from 438a357 to bd23c05 Mar 16, 2018

@takluyver takluyver merged commit 97dd1ed into jupyter:master Mar 16, 2018

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 77.71% (+<.01%) compared to 4493688
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.