Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add settings['activity_sources'] #3401

Merged
merged 2 commits into from Mar 16, 2018
Merged

Conversation

@minrk
Copy link
Member

@minrk minrk commented Mar 6, 2018

for extensions to register activity that should prevent shutdown due to inactivity

for extensions to register activity that should prevent shutdown due to inactivity
@@ -264,6 +264,8 @@ def init_settings(self, jupyter_app, kernel_manager, contents_manager,

# Jupyter stuff
started=now,
# place for extensions to register activity
activity_sources={},
Copy link
Member

@takluyver takluyver Mar 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'sources' suggests to me that it contains something like functions you call to get activity timestamps. Maybe call it something like last_activity_times?

Loading

Copy link
Member

@takluyver takluyver Mar 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @minrk . I can do the name change if you're OK with it.

Loading

Copy link
Member Author

@minrk minrk Mar 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just got back to it

Loading

@takluyver takluyver added this to the 5.5 milestone Mar 13, 2018
@minrk minrk force-pushed the activity_sources branch from 438a357 to bd23c05 Mar 16, 2018
@takluyver takluyver merged commit 97dd1ed into jupyter:master Mar 16, 2018
4 checks passed
Loading
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants