Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript lint in notebooklist.js #3409

Merged
merged 1 commit into from Mar 15, 2018

Conversation

Projects
None yet
1 participant
@takluyver
Copy link
Member

takluyver commented Mar 8, 2018

Like #3294, this cleans up some simple Javascript mistakes, so that we stand a better chance of noticing when the linter sees things that might actually matter.

@takluyver takluyver added this to the 5.5 milestone Mar 8, 2018

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Mar 13, 2018

I'll merge this tomorrow unless anyone wants more time to look.

@takluyver takluyver merged commit 7fb0510 into jupyter:master Mar 15, 2018

4 checks passed

codecov/patch Coverage not affected when comparing c1c7d3d...e2ee7c6
Details
codecov/project 77.71% remains the same compared to c1c7d3d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the takluyver:js-polish-notebooklist branch Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.