Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo patches in teardown before attempting to delete files #3459

Merged
merged 2 commits into from Mar 22, 2018

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Mar 22, 2018

Deleting the directory can fail on windows, which leaves the patches in place for other tests which run afterwards. Unfortunately we can't use addCleanup() with class-level setup/teardown, AFAIK.

This will probably still fail at first (unless the original issue is random), but it should see one test failure on Appveyor rather than 5.

@takluyver takluyver added this to the 5.5 milestone Mar 22, 2018
@takluyver
Copy link
Member Author

@takluyver takluyver commented Mar 22, 2018

As expected, that now has only one failure. Now to figure out what causes that.

@takluyver
Copy link
Member Author

@takluyver takluyver commented Mar 22, 2018

Hmm, it seems that that fixed it. I was kind of hoping that it wouldn't, because I think that means that something isn't getting cleaned up following a request for a static file, so the file is left 'open'. Tornado devs have told us previously that they don't officially support Windows, so we may have to work around this. But for now this makes tests pass on Appveyor.

@mpacer
Copy link
Member

@mpacer mpacer commented Mar 22, 2018

Looks good to me, I'm going to merge.

@mpacer mpacer merged commit e433b81 into jupyter:master Mar 22, 2018
4 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants