Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert jstests to selenium: deletecell.js #3465

Merged
merged 17 commits into from Apr 4, 2018

Conversation

Projects
None yet
2 participants
@Sheshtawy
Copy link
Contributor

Sheshtawy commented Mar 24, 2018

This PR is related to #3335. It's mean to convert the file deletecell.js into a selenium test.

@Sheshtawy Sheshtawy changed the title [WIP] Convert jstests to selenium: deletecell.js Convert jstests to selenium: deletecell.js Apr 2, 2018

notebook.current_cell.send_keys('dd')

def test_delete_cells(notebook):
print('testing deleteable cells')

This comment has been minimized.

@takluyver

takluyver Apr 3, 2018

Member

We shouldn't need this print() - pytest should tell us which test is which when it runs them.

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Apr 3, 2018

Thanks, it looks like the tests are passing now. Are you satisfied that you've converted the whole of deletecell.js? If so, you can delete that file as part of this PR - the aim is to get rid of the Phantom tests as well as creating Selenium ones.

Sheshtawy added some commits Apr 3, 2018

Delete tests
Update  to use the updated notebook fixture

@pytest.fixture
def notebook(authenticated_browser):
return Notebook.new_notebook(authenticated_browser)

def get_cells_contents(nb):

This comment has been minimized.

@Sheshtawy

Sheshtawy Apr 3, 2018

Author Contributor

@takluyver Thanks for taking the time to review my PR. I made some changes to address your comments. I have only one more idea that I'm not sure about and I would like your input. I was thinking of moving this function to the Notebook class since I think it might be needed/repeated in several tests. I'm not sure about other helper functions like delete_cell, cell_is_deletable and set_cell_metadata, do you think they also should be moved to the Notebook class too?

This comment has been minimized.

@takluyver

takluyver Apr 4, 2018

Member

I'd say that the get_cells_contents and set_cell_metadata can move to the notebook class, but let's leave delete_cell and cell_is_deletable here for now. They can always be moved in another PR if we change our minds. :-)

This comment has been minimized.

@Sheshtawy

Sheshtawy Apr 4, 2018

Author Contributor

I made the changes. I believe the PR is ready to be merged if you don't have any more comments :)

@takluyver takluyver added this to the 5.5 milestone Apr 4, 2018

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Apr 4, 2018

Thanks!

@takluyver takluyver merged commit e3ee807 into jupyter:master Apr 4, 2018

4 checks passed

codecov/patch 0% of diff hit (target 0%)
Details
codecov/project 75.01% (-0.4%) compared to 5960203
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.