Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert native for loop to Array forEach() #3477

Merged
merged 1 commit into from Apr 3, 2018
Merged

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Mar 28, 2018

This fixes a problem with variable scoping and closures.

Closes gh-3473

This fixes a problem with variable scoping and closures.

Closes jupytergh-3473
@takluyver takluyver added this to the 5.5 milestone Mar 28, 2018
@takluyver
Copy link
Member Author

@takluyver takluyver commented Apr 2, 2018

I'll merge this tomorrow unless anyone asks for more time to review it.

Loading

@takluyver takluyver merged commit bf5dc5a into jupyter:master Apr 3, 2018
4 checks passed
Loading
@takluyver takluyver deleted the i3473 branch Apr 3, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant