Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert native for loop to Array forEach() #3477

Merged
merged 1 commit into from Apr 3, 2018

Conversation

Projects
None yet
1 participant
@takluyver
Copy link
Member

takluyver commented Mar 28, 2018

This fixes a problem with variable scoping and closures.

Closes gh-3473

Convert native for loop to Array forEach()
This fixes a problem with variable scoping and closures.

Closes gh-3473

@takluyver takluyver added this to the 5.5 milestone Mar 28, 2018

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Apr 2, 2018

I'll merge this tomorrow unless anyone asks for more time to review it.

@takluyver takluyver merged commit bf5dc5a into jupyter:master Apr 3, 2018

4 checks passed

codecov/patch Coverage not affected when comparing faa0cab...9e72e05
Details
codecov/project 76.38% (+0.3%) compared to faa0cab
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the takluyver:i3473 branch Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.