Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigManager should not write out default values found in the .d directory #3485

Merged
merged 3 commits into from May 1, 2018

Conversation

Projects
None yet
2 participants
@maartenbreddels
Copy link
Contributor

maartenbreddels commented Mar 30, 2018

This is a followup of #3116.
When the config manager reads the .json + .d/*.json files, all the data gets merged into one dict. When writted out again, everything ends on in the root .json file. Here I remove all entries that are already present in the .d/*.json files.

For instance, when installing ipyvolume, you end up with the file {prefix}/etc/jupyter/nbconfig/notebook.d/ipyvolume.json. If you now run jupyter nbextension ... for anything, all the data from the ipyvolume.json file ends up in {prefix}/etc/jupyter/nbconfig/notebook.d. Uninstalling ipyvolume will never clean this up, so it will always stay around. This is now avoided by this PR.

@maartenbreddels maartenbreddels changed the title ConfigManager does not write out default values found in the .d directory ConfigManager should not write out default values found in the .d directory Mar 30, 2018

@takluyver takluyver added this to the 5.5 milestone May 1, 2018

@takluyver takluyver merged commit 85b60e2 into jupyter:master May 1, 2018

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 76.46% (+0.38%) compared to faa0cab
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented May 1, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.