Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check links when build is trigger by Travis Cron job #3493

Merged
merged 2 commits into from Apr 4, 2018

Conversation

@ashleytqy
Copy link
Contributor

@ashleytqy ashleytqy commented Apr 3, 2018

Addresses #3292

This line make -C docs/ linkcheck || EXIT_STATUS=$?; that does the link checking will only run if the build is triggered by a cron job.

Let me know if there are any changes to be made!

@takluyver takluyver added this to the 5.5 milestone Apr 4, 2018
@takluyver takluyver merged commit 717294d into jupyter:master Apr 4, 2018
4 checks passed
Loading
@takluyver
Copy link
Member

@takluyver takluyver commented Apr 4, 2018

Thanks @ashleytqy ! 🍪

I've set up the cron job on Travis.

Loading

@takluyver
Copy link
Member

@takluyver takluyver commented Apr 4, 2018

And here's the first cron job running: https://travis-ci.org/jupyter/notebook/builds/362050037

Loading

@takluyver
Copy link
Member

@takluyver takluyver commented Apr 4, 2018

And the link check happens in the cron job, so this is working :-)

https://travis-ci.org/jupyter/notebook/jobs/362050057#L1019

Loading

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants