Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solved waiting asterisk #3494

Merged
merged 2 commits into from Apr 4, 2018

Conversation

Projects
None yet
2 participants
@danagilliann
Copy link
Contributor

danagilliann commented Apr 4, 2018

At the moment, the PR only solves #2460 for an executed cell, meaning if there are other cells running then they will not be "unhanged." Also, the asterisk just gets stripped out meaning the input would look like [] as opposed to [ ]. If anyone has any ideas as to how to solve these issues, please let me know :)

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Apr 4, 2018

For putting the space in there, there's another place in that file where the function is called with no argument (set_input_prompt()). It looks like that should result in a prompt with a gap [ ].

I'm not sure what you mean about other cells running but not executed?

@danagilliann

This comment has been minimized.

Copy link
Contributor Author

danagilliann commented Apr 4, 2018

Got it! Ah so I thought that if I ran multiple cells at once then the other cells wouldn't be affected, but it turns out they are so it's all good!

@takluyver takluyver added this to the 5.5 milestone Apr 4, 2018

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Apr 4, 2018

Thanks @danagilliann, this looks good to me.

@takluyver takluyver merged commit 2fb4716 into jupyter:master Apr 4, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 5960203...e4334e6
Details
codecov/project 75.41% (+<.01%) compared to 5960203
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.