Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to improve web accessibility #3507

Merged
merged 9 commits into from Apr 18, 2018

Conversation

@ashleytqy
Copy link
Contributor

@ashleytqy ashleytqy commented Apr 5, 2018

This PR fixes #3471

Changes

  • Added lang attribute (generated dynamically) which describes the language of the document
  • Labeled form fields
  • De-duplicate id attributes
  • Added name available to accessibility API to password input element

How the page looks after the changes

screen shot 2018-04-05 at 2 13 14 pm

screen shot 2018-04-05 at 1 59 57 pm

Copy link
Member

@takluyver takluyver left a comment

Thanks, this looks good - I've made a couple of notes on the Javascript.

Loading

page_instance.show();
$('input#password_input').focus();

$('input#token_input').focus();
Copy link
Member

@takluyver takluyver Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focus means putting the cursor in an input so that text will appear there when you start typing. So it doesn't make sense to do it for more than one field.

Loading

Copy link
Contributor

@rosaswaby rosaswaby Apr 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danagilliann and I will be working on this!

Loading

@@ -5,9 +5,11 @@ define(['jquery', 'base/js/namespace', 'base/js/page'], function($, IPython, pag
function login_main() {
var page_instance = new page.Page('div#header', 'div#site');
$('button#login_submit').addClass("btn btn-default");
$('button#login_new_pass_submit').addClass("btn btn-default");
Copy link
Member

@takluyver takluyver Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these classes could just be written directly in the HTML, rather than being added by Javascript. I can see it's copied from the line above, but I don't know why that's done in Javascript either.

Loading

Copy link
Contributor Author

@ashleytqy ashleytqy Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing, we’ll fix it!

Loading

Copy link
Contributor

@rosaswaby rosaswaby Apr 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danagilliann and I will be working on this!

Loading

@Carreau
Copy link
Member

@Carreau Carreau commented Apr 18, 2018

Feel free to comment when you have pushed and pull-requests are ready for further review, we are not notified on push

Loading

@takluyver
Copy link
Member

@takluyver takluyver commented Apr 18, 2018

I am actually notified on push now. I thought Github was doing that for everyone? I don't remember changing a setting.

Anyway, this looks good now - thanks all of you who worked on it.

Loading

@takluyver takluyver merged commit fcf5f39 into jupyter:master Apr 18, 2018
4 checks passed
Loading
@takluyver takluyver added this to the 5.5 milestone Apr 24, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants