Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery attribute selector value MUST be surrounded by quotes #3527

Merged
merged 1 commit into from Apr 12, 2018

Conversation

Projects
None yet
2 participants
@elgalu
Copy link
Contributor

elgalu commented Apr 11, 2018

Same problem as ipython/ipyparallel#321

@@ -209,7 +209,7 @@ requirejs([

// load tab if url hash
if (window.location.hash) {
$("#tabs").find("a[href=" + window.location.hash + "]").click();

This comment has been minimized.

@takluyver

takluyver Apr 11, 2018

Member

Thanks! It looks like it's possible to use 'single quotes' (jQuery docs) rather than escaping double quotes, which would be a bit easier to read, IMO. It's not a big deal, though.

This comment has been minimized.

@elgalu

elgalu Apr 12, 2018

Author Contributor

Good point, much more readable. Fixed!

@elgalu elgalu force-pushed the elgalu:attr-selector-surr-quot branch from 5d328b3 to 3d82761 Apr 12, 2018

@elgalu elgalu force-pushed the elgalu:attr-selector-surr-quot branch from 3d82761 to 27710b9 Apr 12, 2018

@takluyver takluyver added this to the 5.5 milestone Apr 12, 2018

@takluyver takluyver merged commit 97b3b96 into jupyter:master Apr 12, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 1c51902...27710b9
Details
codecov/project 75.01% remains the same compared to 1c51902
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Apr 12, 2018

Thanks!

@elgalu elgalu deleted the elgalu:attr-selector-surr-quot branch Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.