Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery attribute selector value MUST be surrounded by quotes #3527

Merged
merged 1 commit into from Apr 12, 2018

Conversation

@elgalu
Copy link
Contributor

@elgalu elgalu commented Apr 11, 2018

Same problem as ipython/ipyparallel#321

@@ -209,7 +209,7 @@ requirejs([

// load tab if url hash
if (window.location.hash) {
$("#tabs").find("a[href=" + window.location.hash + "]").click();
Copy link
Member

@takluyver takluyver Apr 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks like it's possible to use 'single quotes' (jQuery docs) rather than escaping double quotes, which would be a bit easier to read, IMO. It's not a big deal, though.

Loading

Copy link
Contributor Author

@elgalu elgalu Apr 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, much more readable. Fixed!

Loading

@elgalu elgalu force-pushed the attr-selector-surr-quot branch from 5d328b3 to 3d82761 Apr 12, 2018
@elgalu elgalu force-pushed the attr-selector-surr-quot branch from 3d82761 to 27710b9 Apr 12, 2018
@takluyver takluyver added this to the 5.5 milestone Apr 12, 2018
@takluyver takluyver merged commit 97b3b96 into jupyter:master Apr 12, 2018
4 checks passed
Loading
@takluyver
Copy link
Member

@takluyver takluyver commented Apr 12, 2018

Thanks!

Loading

@elgalu elgalu deleted the attr-selector-surr-quot branch Apr 12, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants