Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executing cell when clicking its prompt #3535

Merged
merged 5 commits into from May 23, 2018

Conversation

@lucasoshiro
Copy link
Contributor

@lucasoshiro lucasoshiro commented Apr 16, 2018

Closes #1009. Based on #3437. When clicking on a prompt, executes the corresponding cell.

@takluyver
Copy link
Member

@takluyver takluyver commented Apr 16, 2018

(Repeating my comment from #1009)

Interesting idea! I have some concern that people might be used to clicking on the prompt to select a cell without going into edit mode, and if that suddenly executes the cells, it could be an unpleasant surprise - especially for cells which take a long time to run.

I'll try to think about how we might test it out.

Loading

@lucasoshiro
Copy link
Contributor Author

@lucasoshiro lucasoshiro commented Apr 18, 2018

Thanks for the feedback! I'll think about it

Loading

@lucasoshiro
Copy link
Contributor Author

@lucasoshiro lucasoshiro commented Apr 18, 2018

Hello again. Now, when the mouse is over a cell, a small run icon appears on the left of the prompt:

button_mouse_over

Loading

@takluyver
Copy link
Member

@takluyver takluyver commented Apr 18, 2018

I like this idea for mouse-driven use, though it doesn't help so much on a touchscreen. Maybe we can use some CSS media queries to make these buttons always visible on touch devices?

There's a test failure where a test checks the HTML of the input prompt.

Loading

@lucasoshiro
Copy link
Contributor Author

@lucasoshiro lucasoshiro commented Apr 26, 2018

I have searched a media query for touchscreen devices. I am using any-pointer: coarse. It worked on Chrome, but didn't worked on Firefox, maybe with some javascript it can be solved... I have also fixed that test failure, now the button is outside the prompt div.

Loading

@lucasoshiro
Copy link
Contributor Author

@lucasoshiro lucasoshiro commented May 5, 2018

@takluyver Sadly, any-pointer media query is not supported by some web browsers (https://caniuse.com/#search=any-pointer)... Do you think it's a good idea show the buttons always on those browsers?

Loading

@takluyver
Copy link
Member

@takluyver takluyver commented May 6, 2018

It looks like it's mainly Firefox that doesn't support it, but there's a non-standard -moz-touch-enabled that works there. I found this suggested use on a bug report:

@media (-moz-touch-enabled: 1), (pointer: coarse) {
  // Rules for touch screens
}

https://developer.mozilla.org/en-US/docs/Web/CSS/@media/-moz-touch-enabled

Loading

@lucasoshiro
Copy link
Contributor Author

@lucasoshiro lucasoshiro commented May 19, 2018

That worked here, on a touchscreen computer. Thanks!

Loading

Copy link
Member

@takluyver takluyver left a comment

I've tested this briefly interactively, and it looked good.

Loading

var run_this_cell = $('<div></div>').addClass('run_this_cell');
run_this_cell.prop('title', 'Run this cell');
run_this_cell.append('<i class="fa-step-forward fa"></i>');
run_this_cell.mouseup(function (event) {
Copy link
Member

@takluyver takluyver May 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to do this on the mouseup event rather than the click event? I think we usually use click.

Loading

Copy link
Contributor Author

@lucasoshiro lucasoshiro May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll replace it with click event

Loading

@takluyver takluyver added this to the 6.0 milestone May 23, 2018
@takluyver takluyver removed this from the 6.0 milestone May 23, 2018
@takluyver takluyver added this to the 5.5 milestone May 23, 2018
@takluyver takluyver removed this from the 5.5 milestone May 23, 2018
@takluyver takluyver added this to the 5.6 milestone May 23, 2018
@takluyver takluyver merged commit 374da5a into jupyter:master May 23, 2018
4 checks passed
Loading
@takluyver
Copy link
Member

@takluyver takluyver commented May 23, 2018

Thanks, let's see how this works out. I may ping you if there are issues with it.

Loading

@mpacer mpacer changed the title [WIP] Executing cell when clicking its prompt Executing cell when clicking its prompt Jun 13, 2018
mpacer added a commit to mpacer/notebook that referenced this issue Jun 14, 2018
…yter#3535

Without this change the output and Input areas become unaligned.

This still isn't an ideal fix, but it'll make a release possible without
making the styling problematic.
rgbkrk added a commit that referenced this issue Jun 14, 2018
add el & update css in output_area to match run button in input prompt from #3535
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants