Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [3335] Convert JS tests to Selenium #3554

Merged
merged 2 commits into from Apr 23, 2018

Conversation

Projects
None yet
2 participants
@arovit
Copy link
Contributor

arovit commented Apr 22, 2018

I want to contribute to converting JS tests to selenium tests. This patch is for converting notebook/prompt_numbers.js to selenium/test_prompt_numbers.py.
Also removed notebook/prompt_numbers.js

This is a new PR for 3551

arovit and others added some commits Apr 20, 2018

Merge pull request #1 from jupyter/master
merge from main jupyter/notebook
@arovit

This comment has been minimized.

Copy link
Contributor Author

arovit commented Apr 23, 2018

@takluyver Please review and let me know if anything needs to be improved.

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Apr 23, 2018

BTW, there's no need to open a new PR when someone requests changes - just push more commits to the same branch, and the PR updates.

@takluyver takluyver added this to the 5.5 milestone Apr 23, 2018

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Apr 23, 2018

Looks good, thanks.

@takluyver takluyver merged commit 10b7240 into jupyter:master Apr 23, 2018

4 checks passed

codecov/patch 0% of diff hit (target 0%)
Details
codecov/project 74.78% (-0.23%) compared to fc24f31
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arovit

This comment has been minimized.

Copy link
Contributor Author

arovit commented Apr 23, 2018

thanks @takluyver , looking forward to contributing more.

@arovit arovit deleted the arovit:selenium_test branch Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.