Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [3335] Convert JS tests to Selenium #3554

Merged
merged 2 commits into from Apr 23, 2018
Merged

Conversation

@arovit
Copy link
Contributor

@arovit arovit commented Apr 22, 2018

I want to contribute to converting JS tests to selenium tests. This patch is for converting notebook/prompt_numbers.js to selenium/test_prompt_numbers.py.
Also removed notebook/prompt_numbers.js

This is a new PR for 3551

@arovit
Copy link
Contributor Author

@arovit arovit commented Apr 23, 2018

@takluyver Please review and let me know if anything needs to be improved.

Loading

@takluyver
Copy link
Member

@takluyver takluyver commented Apr 23, 2018

BTW, there's no need to open a new PR when someone requests changes - just push more commits to the same branch, and the PR updates.

Loading

@takluyver takluyver added this to the 5.5 milestone Apr 23, 2018
@takluyver
Copy link
Member

@takluyver takluyver commented Apr 23, 2018

Looks good, thanks.

Loading

@takluyver takluyver merged commit 10b7240 into jupyter:master Apr 23, 2018
4 checks passed
Loading
@arovit
Copy link
Contributor Author

@arovit arovit commented Apr 23, 2018

thanks @takluyver , looking forward to contributing more.

Loading

@arovit arovit deleted the selenium_test branch Apr 23, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants