Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a output_updated.OutputArea event #3560

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Projects
None yet
3 participants
@philippjfr
Copy link
Contributor

philippjfr commented Apr 24, 2018

As outlined in #3557 this PR adds a output_updated.OutputArea event, triggered by update_display_data messages, to match the existing output_added.OutputArea event which is triggered when execute_result and display_data messages are received. Like the output_added event this allows registering callbacks which are given the entire mime bundle and the OutputArea, matching the capability of JupyterLab MIME renderers which are also given the entire mime bundle when update_display_data messages are received.

Let me know if there is some place to document this new event and/or add some kind of test for it (couldn't find either in a cursory search). As an aside, very happy about my first ever contribution to the notebook.

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Apr 24, 2018

Thanks, looks good to me. I'll give @rgbkrk a chance to look at it before I merge, since he has an interest in the rich display machinery.

@takluyver takluyver added this to the 5.5 milestone Apr 24, 2018

@rgbkrk

This comment has been minimized.

Copy link
Member

rgbkrk commented Apr 24, 2018

Sweet, love to have a nice small PR introducing a single event.

@rgbkrk

rgbkrk approved these changes Apr 24, 2018

@takluyver takluyver merged commit ec14450 into jupyter:master Apr 24, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 10b7240...8a9afb4
Details
codecov/project 74.78% remains the same compared to 10b7240
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Apr 24, 2018

Tada! Thank you @philippjfr for your contribution. 🍪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.