Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining keyboard shortcuts for missing actions #3561

Merged
merged 2 commits into from Apr 27, 2018

Conversation

Projects
None yet
1 participant
@takluyver
Copy link
Member

takluyver commented Apr 24, 2018

When users bind custom shortcuts to actions coming from extensions, the shortcuts can be loaded before the extensions, so we need to allow defining a shortcut for an action that doesn't exist yet.

Closes gh-3549
Closes gh-2954

takluyver added some commits Apr 24, 2018

Allow defining keyboard shortcuts for missing actions
When users bind custom shortcuts to actions coming from extensions, the
shortcuts can be loaded before the extensions, so we need to allow
defining a shortcut for an action that doesn't exist yet.

Closes gh-3549
Closes gh-2954

@takluyver takluyver added this to the 5.5 milestone Apr 24, 2018

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Apr 24, 2018

I slipped a few Javascript improvements in while I was touching this file - mostly not relying on for (var key in obj) style iteration, which is well known as a potential source of problems. Since underscore was already used in this file, I relied largely on its _.forEach() function.

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Apr 27, 2018

@parmentelat has confirmed that this fixes the issue they saw.

@takluyver takluyver merged commit 9a3e8ca into jupyter:master Apr 27, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 10b7240...bb1c547
Details
codecov/project 74.78% remains the same compared to 10b7240
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the takluyver:i3549 branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.