Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining keyboard shortcuts for missing actions #3561

Merged
merged 2 commits into from Apr 27, 2018

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Apr 24, 2018

When users bind custom shortcuts to actions coming from extensions, the shortcuts can be loaded before the extensions, so we need to allow defining a shortcut for an action that doesn't exist yet.

Closes gh-3549
Closes gh-2954

takluyver added 2 commits Apr 24, 2018
When users bind custom shortcuts to actions coming from extensions, the
shortcuts can be loaded before the extensions, so we need to allow
defining a shortcut for an action that doesn't exist yet.

Closes jupytergh-3549
Closes jupytergh-2954
@takluyver takluyver added this to the 5.5 milestone Apr 24, 2018
@takluyver
Copy link
Member Author

@takluyver takluyver commented Apr 24, 2018

I slipped a few Javascript improvements in while I was touching this file - mostly not relying on for (var key in obj) style iteration, which is well known as a potential source of problems. Since underscore was already used in this file, I relied largely on its _.forEach() function.

Loading

@takluyver
Copy link
Member Author

@takluyver takluyver commented Apr 27, 2018

@parmentelat has confirmed that this fixes the issue they saw.

Loading

@takluyver takluyver merged commit 9a3e8ca into jupyter:master Apr 27, 2018
4 checks passed
Loading
@takluyver takluyver deleted the i3549 branch Apr 27, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant