Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Require" pyzmq>=17 #3586

Merged
merged 1 commit into from May 1, 2018

Conversation

Projects
None yet
2 participants
@takluyver
Copy link
Member

takluyver commented Apr 30, 2018

Not really a requirement, but explaining about the pyzmq/tornado incompatibility gets old fast.

Closes gh-3579

"Require" pyzmq>=17
Not really a requirement, but explaining about the pyzmq/tornado incompatibility
gets old fast.

Closes gh-3579
@ccordoba12

This comment has been minimized.

Copy link
Contributor

ccordoba12 commented Apr 30, 2018

Thomas, quick question: should this be done for qtconsole too?

@takluyver takluyver added this to the 5.5 milestone Apr 30, 2018

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Apr 30, 2018

Possibly. Have you had many people raising issues due to this incompatibility? I just got tired of explaining it repeatedly, so this should get more people upgraded.

@ccordoba12

This comment has been minimized.

Copy link
Contributor

ccordoba12 commented Apr 30, 2018

Have you had many people raising issues due to this incompatibility?

Yep, we've had our share of issues about it. I'll open a PR i qtconsole to address it then.

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented May 1, 2018

Min already agreed to the idea of doing this, so I'm merging it.

@takluyver takluyver merged commit 464d449 into jupyter:master May 1, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 2aca6f9...7bfa3d0
Details
codecov/project 74.38% remains the same compared to 2aca6f9
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the takluyver:pyzmq17 branch May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.