Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Require" pyzmq>=17 #3586

Merged
merged 1 commit into from May 1, 2018
Merged

"Require" pyzmq>=17 #3586

merged 1 commit into from May 1, 2018

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Apr 30, 2018

Not really a requirement, but explaining about the pyzmq/tornado incompatibility gets old fast.

Closes gh-3579

Not really a requirement, but explaining about the pyzmq/tornado incompatibility
gets old fast.

Closes jupytergh-3579
@ccordoba12
Copy link
Contributor

@ccordoba12 ccordoba12 commented Apr 30, 2018

Thomas, quick question: should this be done for qtconsole too?

Loading

@takluyver takluyver added this to the 5.5 milestone Apr 30, 2018
@takluyver
Copy link
Member Author

@takluyver takluyver commented Apr 30, 2018

Possibly. Have you had many people raising issues due to this incompatibility? I just got tired of explaining it repeatedly, so this should get more people upgraded.

Loading

@ccordoba12
Copy link
Contributor

@ccordoba12 ccordoba12 commented Apr 30, 2018

Have you had many people raising issues due to this incompatibility?

Yep, we've had our share of issues about it. I'll open a PR i qtconsole to address it then.

Loading

@takluyver
Copy link
Member Author

@takluyver takluyver commented May 1, 2018

Min already agreed to the idea of doing this, so I'm merging it.

Loading

@takluyver takluyver merged commit 464d449 into jupyter:master May 1, 2018
4 checks passed
Loading
@takluyver takluyver deleted the pyzmq17 branch May 1, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants