Prefer IP address over hostname when available

[takluyver]

Following discussion on #3356.

@evandam @cyberwillis please let me know if you think this is a good idea. I haven't encountered the same issues as either of you, so I don't want to merge this without some confirmation that it's actually an improvement!

[takluyver]

And are there any other values for self.ip like '0.0.0.0', which can't be directly used?

[cyberwillis]

To me its working fine with this code.
I replicate your changes locally here and tested:

0.0.0.0 : 8888 => container_name : 8888
' ' : 8888 => localhost : 8888
127.0.0.1:8888 => 127.0.0.1 : 8888
xxx.xxx.xxx.xxx : 8888 => xxx.xxx.xxx.xxx : 8888
'*' : 8888 => container_name : 8888

Thanks

[UPDATED @evandam ]

[cyberwillis]

To me this changes are working great !
I tested all the cases.

[evandam]

Looks great to me! Does this handle when you do something like --ip='*'? If I recall it's the same thing as passing 0.0.0.0, too.

[cyberwillis]

Yes, it does. I have tested earlier.

[evandam]

Just read that after I asked. I'm all for this!

[cyberwillis]

:)

[takluyver]

Thanks both! In it goes.