Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer IP address over hostname when available #3593

Merged
merged 2 commits into from May 5, 2018

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented May 4, 2018

Following discussion on #3356.

@evandam @cyberwillis please let me know if you think this is a good idea. I haven't encountered the same issues as either of you, so I don't want to merge this without some confirmation that it's actually an improvement!

@takluyver
Copy link
Member Author

@takluyver takluyver commented May 4, 2018

And are there any other values for self.ip like '0.0.0.0', which can't be directly used?

Loading

@cyberwillis
Copy link

@cyberwillis cyberwillis commented May 4, 2018

To me its working fine with this code.
I replicate your changes locally here and tested:

0.0.0.0 : 8888 => container_name : 8888
' ' : 8888 => localhost : 8888
127.0.0.1:8888 => 127.0.0.1 : 8888
xxx.xxx.xxx.xxx : 8888 => xxx.xxx.xxx.xxx : 8888
'*' : 8888 => container_name : 8888

Thanks

[UPDATED @evandam ]

Loading

Copy link

@cyberwillis cyberwillis left a comment

To me this changes are working great !
I tested all the cases.

Loading

@evandam
Copy link
Contributor

@evandam evandam commented May 5, 2018

Looks great to me! Does this handle when you do something like --ip='*'? If I recall it's the same thing as passing 0.0.0.0, too.

Loading

@cyberwillis
Copy link

@cyberwillis cyberwillis commented May 5, 2018

Yes, it does. I have tested earlier.

Loading

@evandam
Copy link
Contributor

@evandam evandam commented May 5, 2018

Just read that after I asked. I'm all for this!

Loading

@cyberwillis
Copy link

@cyberwillis cyberwillis commented May 5, 2018

:)

Loading

@takluyver takluyver added this to the 5.5 milestone May 5, 2018
@takluyver
Copy link
Member Author

@takluyver takluyver commented May 5, 2018

Thanks both! In it goes.

Loading

@takluyver takluyver merged commit 11743f1 into jupyter:master May 5, 2018
4 checks passed
Loading
@takluyver takluyver deleted the url-prefer-ipaddr branch May 5, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants