Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trash non-empty directories on Windows #3673

Merged
merged 2 commits into from Jun 12, 2018

Conversation

Projects
None yet
2 participants
@takluyver
Copy link
Member

takluyver commented Jun 10, 2018

It appears that the Windows backend of send2trash can't guarantee that files won't actually be deleted. There are some hints that this happens in particular when you delete a lot of data at once. So this returns to refusing to delete folders unless they're empty (or contain only ipynb checkpoints).

Closes gh-3631

takluyver added some commits Jun 10, 2018

Don't trash non-empty directories on Windows
It appears that the Windows backend of send2trash can't guarantee that
files won't actually be deleted. There are some hints that this happens
in particular when you delete a lot of data at once. So this returns to
refusing to delete folders unless they're empty (or contain only ipynb
checkpoints).

Closes gh-3631

@minrk minrk merged commit d9baafa into jupyter:master Jun 12, 2018

4 checks passed

codecov/patch 30.76% of diff hit (target 0%)
Details
codecov/project 74.37% (-0.03%) compared to ebe0176
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@minrk minrk added this to the 5.6 milestone Jun 12, 2018

@takluyver takluyver deleted the takluyver:win-dir-notrash branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.