Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add el & update css in output_area to match run button in input prompt from #3535 #3687

Merged
merged 1 commit into from Jun 14, 2018

Conversation

Projects
None yet
3 participants
@mpacer
Copy link
Member

mpacer commented Jun 14, 2018

Without this change the output and Input areas become unaligned.

This still isn't an ideal fix, but it'll make a release possible without making the styling problematic.

This can be seen as a styling continuation of #3535.

add el & update css in output_area to match run button in In from #3535
Without this change the output and Input areas become unaligned.

This still isn't an ideal fix, but it'll make a release possible without
making the styling problematic.

@mpacer mpacer added this to the 5.6 milestone Jun 14, 2018

@mpacer

This comment has been minimized.

Copy link
Member Author

mpacer commented Jun 14, 2018

@takluyver @minrk @gnestor I don't think this is super controversial (in comparison to 3535), can I get an expedited review so that I can proceed with making a release candidate for 5.6?

@mpacer

This comment has been minimized.

Copy link
Member Author

mpacer commented Jun 14, 2018

Alternatively to a expedited review, if we do want to iterate on this PR a bunch, I'd like to suggest reverting #3535 to make a 5.6 release candidate possible, pushing it until 5.7 (or 5.6.1) when we can figure out a better way to handle the styling issues.

@rgbkrk

rgbkrk approved these changes Jun 14, 2018

@rgbkrk rgbkrk merged commit c852813 into jupyter:master Jun 14, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 1918856...dd282f6
Details
codecov/project 74.09% remains the same compared to 1918856
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gnestor

This comment has been minimized.

Copy link
Contributor

gnestor commented Jun 14, 2018

Thanks @mpacer! Let me know how I can help with 5.6 efforts 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.