Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add `or 127.0.0.1` when listening on all-ips #3703

Merged
merged 1 commit into from Jun 30, 2018

Conversation

Projects
None yet
2 participants
@minrk
Copy link
Member

minrk commented Jun 21, 2018

Effectively reverts #3356 due to issues like #3605. Makes it not a copyable URL anymore, but there’s simply no way for a copyable host to work in general in this case. For folks who want a copyable URL, they can now set display_url via #3668.

add “or 127.0.0.1” for all-ips
Makes it not a copyable URL anymore, but there’s no way for a copyable host to work in general in this case.
@minrk

This comment has been minimized.

Copy link
Member Author

minrk commented Jun 21, 2018

5.4: never connectable, actually the bind address

The Jupyter Notebook is running at:
http://0.0.0.0:8888/?token=

5.5: connectable if hostname is valid (generally true, but not in containers)

The Jupyter Notebook is running at:
http://hostname:8888/?token=

this PR: not connectable directly via copy/paste due to (host, ip) format, but both hosts are connectable. I think the lack of copy/paste-ability is helpful in the docker case, since it's impossible for it to be reliably correct in containers.

The Jupyter Notebook is running at:
http://(hostname or 127.0.0.1):8888/?token=
@minrk

This comment has been minimized.

Copy link
Member Author

minrk commented Jun 21, 2018

@takluyver what do you think of this for addressing the default behavior for 5.6?

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jun 21, 2018

For the record, I can connect to 0.0.0.0 with Firefox on Linux. Not sure which interface that uses, but:

screenshot from 2018-06-21 14-47-07

But this approach seems reasonable to me.

@minrk minrk added this to the 5.6 milestone Jun 29, 2018

@takluyver takluyver merged commit 1b69205 into jupyter:master Jun 30, 2018

4 checks passed

codecov/patch 0% of diff hit (target 0%)
Details
codecov/project 73.77% remains the same compared to b8b6633
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@minrk minrk deleted the minrk:public-host branch Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.