New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:can't choose same file twice when in upload file #3712

Merged
merged 1 commit into from Aug 1, 2018

Conversation

Projects
None yet
3 participants
@forbxy
Contributor

forbxy commented Jun 25, 2018

Clear fileinput value. This is required to reset the form. Otherwise, if you upload a file, delete it and try to upload it again, the changed event won't fire.
the old, replacing fileinput did not work as expected

@forbxy forbxy changed the title from fix:can't choose same file to fix:can't choose same file twice when in upload file Jun 26, 2018

@takluyver

This comment has been minimized.

Member

takluyver commented Jun 30, 2018

Have you tested the old and the new across different browsers? The old code must have worked for someone at some point, so I want to make sure we don't just go from one solution that works for some people to another that works for some other people.

@forbxy

This comment has been minimized.

Contributor

forbxy commented Jul 14, 2018

finally,I test it on safair(11.1), firfox(61),chrome(67).the old code dont't work on chrome, new code work on each browser

@minrk minrk added this to the 5.7 milestone Aug 1, 2018

@minrk minrk merged commit b94cc44 into jupyter:master Aug 1, 2018

4 checks passed

codecov/patch Coverage not affected when comparing b8b6633...c339a34
Details
codecov/project 73.77% remains the same compared to b8b6633
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment