Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfix:can't choose same file twice when in upload file #3712
Conversation
forbxy
changed the title from
fix:can't choose same file
to
fix:can't choose same file twice when in upload file
Jun 26, 2018
This comment has been minimized.
This comment has been minimized.
|
Have you tested the old and the new across different browsers? The old code must have worked for someone at some point, so I want to make sure we don't just go from one solution that works for some people to another that works for some other people. |
This comment has been minimized.
This comment has been minimized.
|
finally,I test it on safair(11.1), firfox(61),chrome(67).the old code dont't work on chrome, new code work on each browser |
minrk
added this to the 5.7 milestone
Aug 1, 2018
minrk
merged commit b94cc44
into
jupyter:master
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
forbxy commentedJun 25, 2018
Clear fileinput value. This is required to reset the form. Otherwise, if you upload a file, delete it and try to upload it again, the changed event won't fire.
the old, replacing fileinput did not work as expected