Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for 'New' dropdown button to be clickable for Selenium tests #3726

Merged
merged 1 commit into from Jul 4, 2018

Conversation

takluyver
Copy link
Member

Selenium tests have been failing intermittently with an ElementNotInteractableException on the line new_button.click(). Restarting the test usually makes it work.

This PR waits for the button to be clickable, rather than just present in the DOM. Hopefully that will prevent the error.

@takluyver
Copy link
Member Author

I restarted the Selenium test job twice on Travis, so it has run three times on this PR, and passed each time. I'm therefore cautiously optimistic that this change is an improvement.

@takluyver takluyver merged commit 9d0ea1a into jupyter:master Jul 4, 2018
@takluyver takluyver deleted the selenium-newnb-clickable branch July 4, 2018 12:53
@minrk minrk added this to the 5.6 milestone Sep 13, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants