Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for 'New' dropdown button to be clickable for Selenium tests #3726

Merged
merged 1 commit into from Jul 4, 2018

Conversation

Projects
None yet
2 participants
@takluyver
Copy link
Member

takluyver commented Jun 30, 2018

Selenium tests have been failing intermittently with an ElementNotInteractableException on the line new_button.click(). Restarting the test usually makes it work.

This PR waits for the button to be clickable, rather than just present in the DOM. Hopefully that will prevent the error.

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Jun 30, 2018

I restarted the Selenium test job twice on Travis, so it has run three times on this PR, and passed each time. I'm therefore cautiously optimistic that this change is an improvement.

@takluyver takluyver merged commit 9d0ea1a into jupyter:master Jul 4, 2018

4 checks passed

codecov/patch 0% of diff hit (target 0%)
Details
codecov/project 74.05% (+0.28%) compared to 1b69205
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the takluyver:selenium-newnb-clickable branch Jul 4, 2018

@minrk minrk added this to the 5.6 milestone Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.