Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable the host check for 5.6 because of gh-3754 #3766
Conversation
takluyver
added this to the 5.6 milestone
Jul 14, 2018
takluyver
referenced this pull request
Jul 14, 2018
Closed
"ValueError: 'fe80::1%lo0' does not appear to be an IPv4 or IPv6 address" error when running notebook #3754
takluyver
merged commit 86e6f79
into
jupyter:master
Jul 14, 2018
4 checks passed
codecov/patch
100% of diff hit (target 0%)
Details
codecov/project
Absolute coverage decreased by -0.17% but relative coverage increased by +26.21% compared to ebc60bc
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
takluyver
deleted the
takluyver:disable-host-check
branch
Jul 14, 2018
This comment has been minimized.
This comment has been minimized.
|
Confirmed that this resolves #3754 |
This comment has been minimized.
This comment has been minimized.
|
To be clear, this is a workaround so I could get a release out quickly - it disables the check for everyone, so I definitely want to find a better solution before the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
takluyver commentedJul 14, 2018
I intend to re-enable this again straight after the release, but for now we want to get 5.6 out without breaking things for lots of Mac users.