New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the host check for 5.6 because of gh-3754 #3766

Merged
merged 1 commit into from Jul 14, 2018

Conversation

Projects
None yet
2 participants
@takluyver
Member

takluyver commented Jul 14, 2018

I intend to re-enable this again straight after the release, but for now we want to get 5.6 out without breaking things for lots of Mac users.

@takluyver takluyver added this to the 5.6 milestone Jul 14, 2018

@takluyver takluyver merged commit 86e6f79 into jupyter:master Jul 14, 2018

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -0.17% but relative coverage increased by +26.21% compared to ebc60bc
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the takluyver:disable-host-check branch Jul 14, 2018

@gnestor

This comment has been minimized.

Contributor

gnestor commented Jul 14, 2018

Confirmed that this resolves #3754 👍

@takluyver

This comment has been minimized.

Member

takluyver commented Jul 14, 2018

To be clear, this is a workaround so I could get a release out quickly - it disables the check for everyone, so I definitely want to find a better solution before the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment