Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix tornado max_body_size & max_buffer_size settings #3829
Conversation
mociarain
added some commits
Aug 7, 2018
mociarain
force-pushed the
mociarain:fix-tornado-settings
branch
from
f33fc6c
to
0827dcb
Aug 7, 2018
This comment has been minimized.
This comment has been minimized.
lihan
commented
Aug 14, 2018
|
+1 |
1 similar comment
This comment has been minimized.
This comment has been minimized.
dewaldabrie
commented
Aug 16, 2018
|
+1 |
This comment has been minimized.
This comment has been minimized.
|
Thank you! |
minrk
added this to the 5.7 milestone
Sep 13, 2018
minrk
merged commit f81ec30
into
jupyter:master
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mociarain commentedAug 7, 2018
•
edited by minrk
The limits for max_body_size and max_buffer_size weren't being correctly passed to the underlying http server. This PR fixes that, using the described defaults, nominally 512MB as opposed to the actual tornado defaults of 100MB, and makes the values configurable.
It solves the following related issues:
closes #3797 and #650