Fix tornado max_body_size & max_buffer_size settings #3829
Merged
Conversation
mociarain
force-pushed the
mociarain:fix-tornado-settings
branch
from
f33fc6c
to
0827dcb
|
+1 |
1 similar comment
|
+1 |
|
Thank you! |
This was referenced Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The limits for max_body_size and max_buffer_size weren't being correctly passed to the underlying http server. This PR fixes that, using the described defaults, nominally 512MB as opposed to the actual tornado defaults of 100MB, and makes the values configurable.
It solves the following related issues:
closes #3797 and #650