New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tornado max_body_size & max_buffer_size settings #3829

Merged
merged 3 commits into from Sep 13, 2018

Conversation

Projects
None yet
4 participants
@mociarain
Contributor

mociarain commented Aug 7, 2018

The limits for max_body_size and max_buffer_size weren't being correctly passed to the underlying http server. This PR fixes that, using the described defaults, nominally 512MB as opposed to the actual tornado defaults of 100MB, and makes the values configurable.

It solves the following related issues:

closes #3797 and #650

@mociarain mociarain force-pushed the mociarain:fix-tornado-settings branch from f33fc6c to 0827dcb Aug 7, 2018

@lihan

This comment has been minimized.

lihan commented Aug 14, 2018

+1

1 similar comment
@dewaldabrie

This comment has been minimized.

dewaldabrie commented Aug 16, 2018

+1

@minrk

This comment has been minimized.

Member

minrk commented Sep 13, 2018

Thank you!

@minrk minrk added this to the 5.7 milestone Sep 13, 2018

@minrk minrk merged commit f81ec30 into jupyter:master Sep 13, 2018

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 73.77% (+<.01%) compared to b94cc44
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment