Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Enter causes page reload in shortcuts editor #3871

merged 1 commit into from Sep 13, 2018


Copy link

@parente parente commented Aug 22, 2018


  1. Open keyboard shortcuts editor
  2. Click to change / assign a keyboard combination
  3. Type the keys to assign
  4. Press the Enter key to save the assignment
  5. Entire browser page refreshes

I think the return false in the current code was meant to stop this from happening, but a call to event.preventDefault() is also required to prevent full-page form submission.

I think the behavior could still use some tweaking since pressing Enter in the dialog even when a shortcut field does not have the edit focus does nothing.

@minrk minrk merged commit 4650dab into jupyter:master Sep 13, 2018
@minrk minrk added this to the 5.7 milestone Sep 13, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants