Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access control headers to be overriden in jupyter_notebook_conf… #3886

Merged
merged 1 commit into from Sep 7, 2018

Conversation

@rwmajor2
Copy link

@rwmajor2 rwmajor2 commented Aug 28, 2018

…ig.py. This will allow for greater CORS and proxy flexibility.

@minrk minrk merged commit 872a6c7 into jupyter:master Sep 7, 2018
4 checks passed
4 checks passed
codecov/patch 0% of diff hit (target 0%)
Details
codecov/project 73.73% (-0.31%) compared to 98085dc
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@minrk
Copy link
Member

@minrk minrk commented Sep 7, 2018

Thanks!

@minrk minrk added this to the 5.7 milestone Sep 13, 2018
@chilijung
Copy link

@chilijung chilijung commented May 16, 2019

Hi, how does this work? I try to setup from ~/.jupyter/jupyter_notebook_config.py, but no success... or should I setup the settings elsewhere? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants