Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix base URL to breadcrumb root URL #3905

Merged
merged 1 commit into from Sep 13, 2018

Conversation

@KGHustad
Copy link
Contributor

@KGHustad KGHustad commented Sep 10, 2018

The base URL was only prefixed to the breadcrumbs following the root.
See jupyterhub/jupyterhub#2137 for the full problem description.

The base URL was only prefixed to the breadcrumbs following the root.
See jupyterhub/jupyterhub#2137 for problem
description.
@minrk minrk merged commit 0da9648 into jupyter:master Sep 13, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@minrk
Copy link
Member

@minrk minrk commented Sep 13, 2018

Thanks!

@minrk minrk added this to the 5.7 milestone Sep 13, 2018
@KGHustad KGHustad deleted the KGHustad:breadcrumb-root-url-fix branch Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants