Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try rebuild translation js #3925

Merged
merged 4 commits into from Sep 18, 2018
Merged

Try rebuild translation js #3925

merged 4 commits into from Sep 18, 2018

Conversation

@Carreau
Copy link
Member

@Carreau Carreau commented Sep 15, 2018

Having translations in the core if we don't package them does not make much sens IMHO.

THis is an attempt at fixing that (need to figure out if we should unconditionally depend on Babel to build the SDist on user machine).

@Carreau Carreau added this to the 5.7 milestone Sep 15, 2018
@Carreau Carreau force-pushed the Carreau:package-translations branch from 8f33f8a to 0c00157 Sep 16, 2018
Make sure they are included in sdist/wheel.
@Carreau Carreau force-pushed the Carreau:package-translations branch 3 times, most recently from 8a43e26 to c53a5cc Sep 16, 2018
@Carreau Carreau force-pushed the Carreau:package-translations branch from c53a5cc to 07126ca Sep 16, 2018
minrk added 2 commits Sep 17, 2018
- no global installation
- invoke with node
for better output
@minrk minrk merged commit 33ec644 into jupyter:master Sep 18, 2018
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing bb07253...e78f438
Details
codecov/project 73.75% remains the same compared to bb07253
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@minrk minrk deleted the Carreau:package-translations branch Sep 18, 2018
@Carreau
Copy link
Member Author

@Carreau Carreau commented Sep 18, 2018

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants