Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for socket permission errors on Cygwin #4584

Merged
merged 2 commits into from Jun 7, 2020

Conversation

embray
Copy link
Contributor

@embray embray commented Apr 23, 2019

As reported first here, when running on Cygwin if the notebook server tries to bind on the default port (say 8888) and this results in a permission error for some reason (perhaps a service is installed that as exclusive permission to use that port) the notebook server crashes instead of automatically trying another port.

I confirmed that this is likely due to a bug in Cygwin such that it does not properly map the WSAEACCES winsock error code to the POSIX EACCES.

This provides a simple workaround--unfortunately the workaround can in principle mask other errors (since the EPERM set by Cygwin is a default fallback for unrecognized winsock errors), but this is going to be the most likely culprit for users.

@embray
Copy link
Contributor Author

embray commented Apr 23, 2019

Error on Travis appears to be spurious.

@blink1073
Copy link
Member

Kicking CI.

@blink1073 blink1073 closed this Jun 7, 2020
@blink1073 blink1073 reopened this Jun 7, 2020
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073 blink1073 merged commit 8e7c99a into jupyter:master Jun 7, 2020
@blink1073 blink1073 added this to the 6.1 milestone Jun 7, 2020
@embray embray deleted the cygwin/bind-eperm branch June 8, 2020 12:12
@embray
Copy link
Contributor Author

embray commented Jun 8, 2020

Oh cool, I forgot about this. Thanks for accepting the fix.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants