Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips visible through keyboard navigation for specified buttons: issue #3964 #4729

Merged
merged 2 commits into from Jun 7, 2020

Conversation

joshuazeltser
Copy link
Contributor

Fixed issue #3964. We have fixed the tooltips for the "Duplicate", "View", "Edit", "Delete" buttons, so that they are visible when navigated to using the keyboard.

@takluyver
Copy link
Member

I don't pretend to be an expert, but I find it hard to believe we need all this. Tooltips have been a standard browser feature for ages, and the buttons have aria-label to expose them to screenreaders. Surely there's some way to make this information visible for keyboard navigation without reimplementing tooltips in a pile of CSS?

@joshuazeltser
Copy link
Contributor Author

joshuazeltser commented Jul 14, 2019

From the research we have done just using the title attribute does not work as a tooltip when using focus (as explained here: title attribute). We, therefore, had to implement it in a different way in order for this to work

@blink1073 blink1073 added this to the 6.1 milestone Jun 7, 2020
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit fb08a1b into jupyter:master Jun 7, 2020
magdapoppins added a commit to magdapoppins/notebook that referenced this pull request Aug 12, 2020
- Change the scope of styles specific to `.dynamic-buttons` to that class only (introed in jupyter#4729)
- Drop the width style from tooltips since `display: inline` makes it have no effect

Fixes jupyter#5670
magdapoppins added a commit to magdapoppins/notebook that referenced this pull request Aug 12, 2020
- Change the scope of styles specific to `.dynamic-buttons` to that class only (introed in jupyter#4729)
- Drop the width style from tooltips since `display: inline` makes it have no effect

Fixes jupyter#5670
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants