Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing react-dom js to package data #4772

Merged
merged 1 commit into from Aug 6, 2019

Conversation

minrk
Copy link
Member

@minrk minrk commented Jul 18, 2019

this file was omitted when react was added, so it is not installed.

closes #4771

@minrk minrk added this to the 6.0.1 milestone Jul 18, 2019
@tm731531
Copy link

how can i insall 6.0.1 version
i use pip install notebook==6.0.1
it is not work for me
or how can I get js file?
thanks

@neilkatin
Copy link

how can i insall 6.0.1 version
i use pip install notebook==6.0.1
it is not work for me
or how can I get js file?
thanks

As a workaround I grabbed the file from: https://unpkg.com/react-dom@16/umd/react-dom.production.min.js and copied it into the jupyter static package tree .../site_packages/notebook/static/components/react

@lresende
Copy link
Member

There is no 6.0.1 release yet, should we start planning/preparing one?

Copy link
Contributor

@dleen dleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@koren88i
Copy link

koren88i commented Aug 2, 2019

i am putting the file in the new env. i do not get the error but opening a new notebook does not work.

@jeremysze
Copy link

I also have this issue. Where can I find ".../site_packages/notebook/static/components/react" to place the react-dom.production.min.js file?

Copy link
Member

@lresende lresende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lresende lresende merged commit 5c43809 into jupyter:master Aug 6, 2019
@VipinindKumar
Copy link

@jeremysze I found the directory here /home/user-name/.local/lib/python3.7/site-packages/notebook/static/components/react on ubunutu

and the error of missing this file is gone.

but now I'm getting a new error of missing file 404 GET /nbextensions/widgets/notebook/js/extension.js?v=20190807184008 when importing tensorflow

maybe this will help in fixing yours

@meeseeksmachine
Copy link

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/jupyter-notebook-error-message/1858/2

@maxwf42
Copy link

maxwf42 commented Aug 15, 2019

Where can I find the directory on a mac?

@yihanhu97
Copy link

yihanhu97 commented Aug 19, 2019

how can i insall 6.0.1 version
i use pip install notebook==6.0.1
it is not work for me
or how can I get js file?
thanks

As a workaround I grabbed the file from: https://unpkg.com/react-dom@16/umd/react-dom.production.min.js and copied it into the jupyter static package tree .../site_packages/notebook/static/components/react

@neilkatin @VipinindKumar couldn't find the folder named notebook. I have no problem locating site_packages. I am currently running python 3.5 on Raspberry Pi and I also ran into the same jupyter notebook issus. Any thoughts? Thank you!

@pjdw
Copy link

pjdw commented Aug 21, 2019

/.local/lib/python3.7/site-packages/notebook/static/components/react

Where can I find the directory on a mac?

/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/notebook/static/components/react

@spring-haru
Copy link

I had the same problem in the case where JN was started when a particular env was active on Mac. The error has gone after the react-dom.production.min.js file was copied into the following folder:

<my_user_name>/anaconda3/envs/<my_env_namei>/lib/python3.7/site-packages/notebook/static/components/react

@ruleGreen
Copy link

how can i insall 6.0.1 version
i use pip install notebook==6.0.1
it is not work for me
or how can I get js file?
thanks

Do you figure it out?
I meet this problem today and I can not degrade tornado to less than vision 5.0.0 cause the notebook 6.0.0 required tornado >= 5.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing “react-dom.production.min.js” file