Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to re-establish websocket connection to Gateway #4777

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@esevan
Copy link
Contributor

commented Jul 23, 2019

When notebook (with --gateway-url option) lost the connection to
Gateway, notebook didn't connect to Gateway again although the
websocket connection from the client was still alive.

This change recovers the connection to Gateway to prevent this anomaly.

Signed-off-by: Eunsoo Park esevan.park@gmail.com

This is from jupyter/nb2kg#42 PR

Attempt to re-establish websocket connection to Gateway
When notebook (with `--gateway-url` option) lost the connection to
Gateway, notebook didn't connect to Gateway again although the
websocket connection from the client was still alive.

This change recovers the connection to Gateway to prevent this anomaly.

Signed-off-by: Eunsoo Park <esevan.park@gmail.com>
@kevin-bates
Copy link
Member

left a comment

Thanks for the port Evan!

@lresende lresende added this to the 6.0.1 milestone Aug 6, 2019

@lresende lresende merged commit 20c2c66 into jupyter:master Aug 7, 2019

4 checks passed

codecov/patch 0% of diff hit (target 0%)
Details
codecov/project 69.04% (-0.06%) compared to e498de6
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@esevan esevan deleted the esevan:recover_sessions_for_gateway branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.