Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for more RTL languages #5036

Merged
merged 1 commit into from Jun 3, 2020

Conversation

m2-farzan
Copy link
Contributor

The notebook switches to right-to-left layout when the browser language is set to Arabic or Hebrew. However there are more RTL languages in the world, e.g. Persian and Urdu.

This patch adds the ISO 639 codes for more RTL languages. It's almost a copy-paste from a ruby gem and here is their reference for the language list.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073 blink1073 added this to the 6.1 milestone Jun 3, 2020
@blink1073 blink1073 merged commit 80fc3c8 into jupyter:master Jun 3, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants